Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cilogon credentials and support #823

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

GeorgianaElena
Copy link
Member

Reference: #315

@GeorgianaElena GeorgianaElena changed the title Add cilogon credentials Add cilogon credentials and support Nov 22, 2021
@GeorgianaElena
Copy link
Member Author

Friendly ping to @2i2c-org/tech-team ➡️ Do you see any reason for not merging this (given the context in #315 (comment))? (Other than there are no docs around this yet, but promise to add them once this gets approved)

@choldgraf
Copy link
Member

choldgraf commented Jan 6, 2022

Here's the comment where we decided which one to implement: #315 (comment)

It looks like the main thing that this does is adds our CILogon credentials to the deployment configuration etc. So is this correct:

  1. We have set up an application on CILogon, and this gave us some kind of credential which we're adding in this PR.
  2. If a community wants to use CILogon, in their hub configuration we'll need to configure the regex to support it. Here's an example of the configuration we would need:
    hub:
    config:
    Authenticator:
    admin_users: &mills_admins
    - <staff_google_ids>
    - [email protected]
    - [email protected]
    - [email protected]
    - [email protected]
    username_pattern: '^(.+@mills\.edu|yuvipanda@2i2c\.org|choldgraf@2i2c\.org|georgianaelena@2i2c\.org|sgibson@2i2c\.org|erik@2i2c\.org|damianavila@2i2c\.org|aculich@berkeley\.edu|jpercy@berkeley\.edu|deployment-service-check)$'
  3. So once this PR is merged, we'll be able to add the hub authentication configuration to make Auth0 provide a "CILogon" button for authentication.

Is that right?

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this one in, and then go through the process of setting up CILogon for a test hub to see if / how it works. I'm +1 to merge as long as we track these next steps in the other issue. Will update it so we don't forget

@GeorgianaElena
Copy link
Member Author

I follow @choldgraf's suggestion and merge this, then track follow-up doc PRs in the original issue. Thanks @choldgraf!

@GeorgianaElena GeorgianaElena merged commit f57adb9 into 2i2c-org:master Jan 11, 2022
@GeorgianaElena GeorgianaElena deleted the cilogon-secrets branch January 13, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants